linux-kernel - Re: [PATCH 2/2] platform/x86/intel/ifs: Initialize AMX state for the scan test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjGHdwDXxhhqXANq@a4bf019067fa.jf.intel.com>
Date: Tue, 30 Apr 2024 17:06:15 -0700
From: Ashok Raj <ashok.raj@...el.com>
To: "Chang S. Bae" <chang.seok.bae@...el.com>
CC: <linux-kernel@...r.kernel.org>, <x86@...nel.org>,
	<platform-driver-x86@...r.kernel.org>, <tglx@...utronix.de>,
	<mingo@...hat.com>, <bp@...en8.de>, <dave.hansen@...ux.intel.com>,
	<hdegoede@...hat.com>, <ilpo.jarvinen@...ux.intel.com>,
	<tony.luck@...el.com>, <jithu.joseph@...el.com>, Ashok Raj
	<ashok.raj@...el.com>
Subject: Re: [PATCH 2/2] platform/x86/intel/ifs: Initialize AMX state for the
 scan test

On Tue, Apr 30, 2024 at 02:25:08PM -0700, Bae, Chang Seok wrote:
> The scan test does not start when the AMX state remains active and is not
> re-initialized. With the extension of kernel_fpu_begin_mask(), the driver
> code can now initialize the state properly.

Avoid "re-initialized" and maybe use the same SDM language here as well?

	Infield Scan aborts if AMX state is not in initialized state. Use
	the kernel_fpu_begin_mask(KFPU_AMX) to ensure AMX state is initialized.

> 
> Introduce custom FPU handling wrappers to ensure compliant with the
> established FPU API semantics, as kernel_fpu_begin() exclusively sets
> legacy states. This follows the EFI case from commit b0dc553cfc9d
> ("x86/fpu: Make the EFI FPU calling convention explicit").

The EFI and commit mention is worthy of prior use, but the first line
isn't reading well... Maybe

	Introduce custom FPU handling wrappers to ensure compliance with the 
	established FPU API semantics.  This change follows the EFI case from 
	commit b0dc553cfc9d ("x86/fpu: Make the EFI FPU calling convention explicit").

I dropped the note about legacy states, I didn't quite know how to word
that.

> 
> Then, use these wrappers to surround the MSR_ACTIVATE_SCAN write to
> minimize the critical section. To prevent unnecessary delays, invoke
> ifs_fpu_begin() before entering the rendezvous loop.
> 
> Signed-off-by: Chang S. Bae <chang.seok.bae@...el.com>
> Reviewed-by: Jithu Joseph <jithu.joseph@...el.com>
> Tested-by: Jithu Joseph <jithu.joseph@...el.com>