linux-kernel - Re: [PATCH 1/2] media: bcm2835-unicam: Drop usage of of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_3E5M4uWoX0sOTxji9Rj25xajh9jbyJOSBsa+MV_h_GaA@mail.gmail.com>
Date: Wed, 1 May 2024 13:03:42 +0200
From: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: linux-media@...r.kernel.org, 
	Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Naushir Patuck <naush@...pberrypi.com>, Dave Stevenson <dave.stevenson@...pberrypi.com>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-rpi-kernel@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] media: bcm2835-unicam: Drop usage of of_match_ptr()

Hi Laurent

This is a dupe of:

https://patchwork.linuxtv.org/project/linux-media/patch/20240430-fix-ipu6-v1-1-9b31fbbce6e4@chromium.org/

regards!

On Tue, Apr 30, 2024 at 11:39 PM Laurent Pinchart
<laurent.pinchart@...asonboard.com> wrote:
>
> Using of_match_ptr() to set the .of_match_table field of the device
> driver results in the unicam_of_match table being unused on non-OF
> platforms, causing a compilation warning. Fix it by dropping usage of
> of_match_ptr(), which can be done because the .of_match_table field is
> part of the device_driver structure regardless of whether or not
> CONFIG_OF is selected.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@intel.com/
> ---
>  drivers/media/platform/broadcom/bcm2835-unicam.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> index bd2bbb53070e..c590e26fe2cf 100644
> --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> @@ -2733,7 +2733,7 @@ static struct platform_driver unicam_driver = {
>         .driver = {
>                 .name   = UNICAM_MODULE_NAME,
>                 .pm     = pm_ptr(&unicam_pm_ops),
> -               .of_match_table = of_match_ptr(unicam_of_match),
> +               .of_match_table = unicam_of_match,
>         },
>  };
>
> --
> Regards,
>
> Laurent Pinchart
>
>


-- 
Ricardo Ribalda