linux-kernel - Re: [PATCH v2] ALSA: ASoc/tas2781: Fix wrong loading calibrated data sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 1 May 2024 15:55:32 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Shenghao Ding <shenghao-ding@...com>, alsa-devel@...a-project.org,
 kernel-janitors@...r.kernel.org, Mark Brown <broonie@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Baojun Xu <Baojun.Xu@....com>, Baojun Xu <baojun.xu@...com>,
 Bard Liao <bard.liao@...el.com>, Bard Liao
 <yung-chuan.liao@...ux.intel.com>,
 Cameron Berkenpas <cameron.berkenpas@...il.com>, Gergo Koteles
 <soyer@....hu>, Jaroslav Kysela <perex@...ex.cz>, Kevin Lu
 <kevin-lu@...com>, Liam Girdwood <lgirdwood@...il.com>,
 Liam Girdwood <liam.r.girdwood@...el.com>, mimperial@...ovo.com,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
 Shenghao Ding <13916275206@....com>, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH v2] ALSA: ASoc/tas2781: Fix wrong loading calibrated data
 sequence

…
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
…
> @@ -2151,6 +2151,20 @@ static int tasdevice_load_data(struct tasdevice_priv *tas_priv,
>  	return ret;
>  }
>
> +static void tasdev_load_calibrated_data(struct tasdevice_priv *priv,
> +	int i)

Please put the second function parameter into the previous line.


…
> +	if (cal_fmw) {
> +		struct tasdevice_calibration *cal = cal_fmw->calibrations;
> +
> +		if (cal)
> +			load_calib_data(priv, &cal->dev_data);
> +		return;

Would this statement be redundant at the moment?


> +	}
> +}


Regards,
Markus