linux-kernel - Re: [PATCH 1/2] staging: pi433: Use class_create instead of class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024050109-reward-vision-58e9@gregkh>
Date: Wed, 1 May 2024 16:12:48 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Shahar Avidar <ikobh7@...il.com>
Cc: hverkuil-cisco@...all.nl, andriy.shevchenko@...ux.intel.com,
	robh@...nel.org, felixkimbu1@...il.com, dan.carpenter@...aro.org,
	krzysztof.kozlowski@...aro.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: pi433: Use class_create instead of
 class_register.

On Wed, May 01, 2024 at 08:58:19AM +0300, Shahar Avidar wrote:
> Make use of a higher level API.

What does this mean?

> Reduce global memory allocation from struct class to pointer size.

No, you increased memory allocation here, why do you think you reduced
it?

Also, this looks like a revert of commit f267da65bb6b ("staging: pi433:
make pi433_class constant"), accepted a few months ago, why not just
call it out as an explicit revert if that's what you want to do?

class_create is going away "soon", why add this back when people are
working so hard to remove its usage?  What tutorial did you read that
made you want to make this change?

thanks,

greg k-h