linux-kernel - Re: [PATCH -mm 1/2] nilfs2: use integer type instead of enum req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <650ed9f6-fa50-4a3b-939d-633f9e389137@acm.org>
Date: Wed, 1 May 2024 16:42:35 +0200
From: Bart Van Assche <bvanassche@....org>
To: Ryusuke Konishi <konishi.ryusuke@...il.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH -mm 1/2] nilfs2: use integer type instead of enum req_op
 for event tracing header

On 4/30/24 10:00, Ryusuke Konishi wrote:
>   	trace_nilfs2_mdt_submit_block(inode, inode->i_ino, blkoff,
> -				      opf & REQ_OP_MASK);
> +				      (__force int)(opf & REQ_OP_MASK));

Please keep the enum req_op type instead of casting that type away with
"__force int".

Thanks,

Bart.