linux-kernel - Re: [PATCH] x86/efi: mark racy access on efi_rts_work.efi_rts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tencent_B777D0238556D2AEB121ED8D2151D8BD8E06@qq.com>
Date: Wed,  1 May 2024 10:59:28 +0800
From: linke li <lilinke99@...com>
To: ardb@...nel.org
Cc: bp@...en8.de,
	dave.hansen@...ux.intel.com,
	hpa@...or.com,
	lilinke99@...com,
	linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mingo@...hat.com,
	tglx@...utronix.de,
	x86@...nel.org,
	xujianhao01@...il.com
Subject: Re: [PATCH] x86/efi: mark racy access on efi_rts_work.efi_rts_id

> Why is this the only reference that needs an annotation?

In the function efi_runtime_services_init(), the if check on
efi_rts_work.efi_rts_id in line 728 uses READ_ONCE(), and the comment
explains that this is to reduce reports from KTSAN.

I propose that the check in line 754 undergoes a similar treatment for
consistency and to potentially reduce sanitizer reports.

Thank you.