linux-kernel - Re: [net-next PATCH v3 3/9] octeontx2-pf: Create representor netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 1 May 2024 19:18:13 +0100
From: Simon Horman <horms@...nel.org>
To: Geetha sowjanya <gakula@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kuba@...nel.org,
	davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
	sgoutham@...vell.com, sbhatta@...vell.com, hkelam@...vell.com
Subject: Re: [net-next PATCH v3 3/9] octeontx2-pf: Create representor netdev

On Sun, Apr 28, 2024 at 04:23:06PM +0530, Geetha sowjanya wrote:
> Adds initial devlink support to set/get the switchdev mode.
> Representor netdevs are created for each rvu devices when
> the switch mode is set to 'switchdev'. These netdevs are
> be used to control and configure VFs.
> 
> Signed-off-by: Geetha sowjanya <gakula@...vell.com>

Hi again,

I missed the following when preparing my previous email.

..

> @@ -113,6 +162,7 @@ int otx2_register_dl(struct otx2_nic *pfvf)
>  	devlink_free(dl);
>  	return err;
>  }
> +EXPORT_SYMBOL(otx2_register_dl);
>  
>  void otx2_unregister_dl(struct otx2_nic *pfvf)
>  {
> @@ -124,3 +174,4 @@ void otx2_unregister_dl(struct otx2_nic *pfvf)
>  				  ARRAY_SIZE(otx2_dl_params));
>  	devlink_free(dl);
>  }
> +EXPORT_SYMBOL(otx2_unregister_dl);

otx2_devlink.o is linked into both rvu_nicpf.ko and rvu_nicpf.ko.
The two exports above result in the following errors when building
with allmodconfig on x86_64

 ERROR: modpost: drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf: 'otx2_register_dl' exported twice. Previous export was in drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicpf.ko
 ERROR: modpost: drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicvf: 'otx2_unregister_dl' exported twice. Previous export was in drivers/net/ethernet/marvell/octeontx2/nic/rvu_nicpf.ko

..