linux-kernel - Re: [PATCH] cxl/cper: Fix non-ACPI-APEI-GHES build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66328f2caac87_1384629462@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Date: Wed, 1 May 2024 11:51:24 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Ira Weiny <ira.weiny@...el.com>, Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>, Dave Jiang
	<dave.jiang@...el.com>, Alison Schofield <alison.schofield@...el.com>, Vishal
 Verma <vishal.l.verma@...el.com>, Dan Williams <dan.j.williams@...el.com>
CC: <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "kernel test
 robot" <lkp@...el.com>, Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH] cxl/cper: Fix non-ACPI-APEI-GHES build

Ira Weiny wrote:
> If ACPI_APEI_GHES is not configured the [un]register work functions are
> not properly declared.
> 
> Fix copy paste error.

Copy paste? I would just say:

0day notices that the cxl_cper_register_work() declaration in the
CONFIG_ACPI_APEI_GHES=n is broken, fix it to be typical nop stub.

> 
> Reported-by: kernel test robot <lkp@...el.com>

Checkpatch asks for Closes: tags these days:

Closes: http://lore.kernel.org/r/202405012230.6kXItWen-lkp@intel.com

With that,

Reviewed-by: Dan Williams <dan.j.williams@...el.com>