linux-kernel - Re: [PATCH] cxl/region: Fix cxlr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 1 May 2024 21:23:12 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Li Zhijian <lizhijian@...itsu.com>, linux-cxl@...r.kernel.org,
 kernel-janitors@...r.kernel.org,
 Alison Schofield <alison.schofield@...el.com>,
 Dan Williams <dan.j.williams@...el.com>, Dave Jiang <dave.jiang@...el.com>,
 Davidlohr Bueso <dave@...olabs.net>, Ira Weiny <ira.weiny@...el.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Vishal Verma <vishal.l.verma@...el.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/region: Fix cxlr_pmem leaks

> Before this error path, cxlr_pmem pointed to a kzalloc() memory, free
> it to avoid this memory leaking.

Can the following wording be a bit nicer?

   The local variable “cxlr_pmem” referred to dynamically allocated memory.
   Free it in one error case before it is reset to an error pointer.


Would the summary phrase “Fix a memory leak in cxl_pmem_region_alloc()”
be more appropriate here?

Regards,
Markus