linux-kernel - Re: [PATCH net-next v7 4/5] ptp: clockmatrix: Fix caps.max_adj to reflect DPLL_MAX_FREQ_OFFSET[MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 2 May 2024 08:54:54 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Min Li <lnimi@...mail.com>
CC: <richardcochran@...il.com>, <lee@...nel.org>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, Min Li
	<min.li.xe@...esas.com>
Subject: Re: [PATCH net-next v7 4/5] ptp: clockmatrix: Fix caps.max_adj to
 reflect DPLL_MAX_FREQ_OFFSET[MAX_FFO]

The 05/01/2024 12:03, Min Li wrote:

Hi Min Li,

Maybe the entire patch should target net instead of net-next. As this is
fixing an issue.

> @@ -2285,6 +2301,10 @@ static int idtcm_enable_channel(struct idtcm *idtcm, u32 index)
>                 ppd->chan = index;
>         }
> 
> +       err = initialize_max_adj(channel);
> +       if (err)
> +               return err;
> +
>         err = initialize_dco_operating_mode(channel);
>         if (err)
>                 return err;
> @@ -2437,8 +2457,13 @@ static int idtcm_probe(struct platform_device *pdev)
> 
>         err = idtcm_load_firmware(idtcm, &pdev->dev);
> 
> -       if (err)
> +       if (err) {
> +               if (err == -ENOENT) {
> +                       mutex_unlock(idtcm->lock);
> +                       return -EPROBE_DEFER;
> +               }
>                 dev_warn(idtcm->dev, "loading firmware failed with %d", err);
> +       }
> 
>         wait_for_chip_ready(idtcm);
> 

Also this change should be in a separate patch as this doesn't have
anything to do with caps.max_adj but it is releasing the lock in case
firmware fails to be loaded.

-- 
/Horatiu