[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ttjgk6ph.wl-tiwai@suse.de>
Date: Thu, 02 May 2024 09:34:34 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Simon Trimmer <simont@...nsource.cirrus.com>
Cc: <tiwai@...e.com>,
<linux-sound@...r.kernel.org>,
<alsa-devel@...a-project.org>,
<linux-kernel@...r.kernel.org>,
<patches@...nsource.cirrus.com>
Subject: Re: [PATCH] ALSA: hda: cs35l56: Perform firmware download in the background
On Wed, 01 May 2024 13:17:55 +0200,
Simon Trimmer wrote:
> @@ -964,6 +1011,14 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
> mutex_init(&cs35l56->base.irq_lock);
> dev_set_drvdata(cs35l56->base.dev, cs35l56);
>
> + cs35l56->dsp_wq = create_singlethread_workqueue("cs35l56-dsp");
> + if (!cs35l56->dsp_wq) {
> + ret = -ENOMEM;
> + goto err;
> + }
Do we really need a dedicated workqueue? In most usages, simple
schedule_work*() works fine and is recommended.
thanks,
Takashi
Powered by blists - more mailing lists