linux-kernel - Re: [PATCH RFC v2 2/4] clk: thead: Add support for T-Head TH1520 AP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 2 May 2024 09:47:46 +0200
From: Thomas Bonnefille <thomas.bonnefille@...tlin.com>
To: Drew Fustini <dfustini@...storrent.com>,
 Jisheng Zhang <jszhang@...nel.org>, Guo Ren <guoren@...nel.org>,
 Fu Wei <wefu@...hat.com>, Yangtao Li <frank.li@...o.com>,
 Emil Renner Berthing <emil.renner.berthing@...onical.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH RFC v2 2/4] clk: thead: Add support for T-Head TH1520
 AP_SUBSYS clocks



On 4/27/24 2:10 AM, Drew Fustini wrote:
> Add support for the AP sub-system clock controller in the T-Head TH1520.
> This include CPU, DPU, GMAC and TEE PLLs.
> 
> Link: https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20System%20User%20Manual.pdf
> Co-developed-by: Yangtao Li <frank.li@...o.com>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> Co-developed-by: Jisheng Zhang <jszhang@...nel.org>
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> Signed-off-by: Drew Fustini <dfustini@...storrent.com>

> ...

> +void ccu_disable_helper(struct ccu_common *common, u32 gate)
> +{
> +	if (!gate)
> +		return;
> +
> +	regmap_update_bits(common->map, common->reg,
> +			   gate, ~gate);
> +}
> +
> +int ccu_enable_helper(struct ccu_common *common, u32 gate)
> +{
> +	if (!gate)
> +		return 0;
> +
> +	return regmap_update_bits(common->map, common->reg,
> +				  gate, gate);
> +}
> +

Both of those functions are only used in this file, you should probably 
make them static because otherwise, the compilation process will prompt 
a "missing prototype" warning.

Thomas