linux-kernel - Re: [PATCH] iio: tmag5273: Remove some unused field in struct tmag5273

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <785c080e-c133-40f1-9b15-2854827a0a0d@wolfvision.net>
Date: Thu, 2 May 2024 10:01:20 +0200
From: Gerald Loacker <gerald.loacker@...fvision.net>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: tmag5273: Remove some unused field in struct
 tmag5273_data

Hi Christophe,

Am 01.05.2024 um 13:28 schrieb Christophe JAILLET:
> In "struct tmag5273_data", the 'scale' and 'vcc' fields are unused.
> Remove them.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only.
> 
> It was added in the initial commit 866a1389174b ("iio: magnetometer: add
> ti tmag5273 driver") but was never used.
> ---
>  drivers/iio/magnetometer/tmag5273.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
> index 218b1ce076c1..4187abe12784 100644
> --- a/drivers/iio/magnetometer/tmag5273.c
> +++ b/drivers/iio/magnetometer/tmag5273.c
> @@ -118,11 +118,9 @@ struct tmag5273_data {
>  	unsigned int version;
>  	char name[16];
>  	unsigned int conv_avg;
> -	unsigned int scale;
>  	enum tmag5273_scale_index scale_index;
>  	unsigned int angle_measurement;
>  	struct regmap *map;
> -	struct regulator *vcc;
>  
>  	/*
>  	 * Locks the sensor for exclusive use during a measurement (which

Thanks for cleaning up.

Reviewed-by: Gerald Loacker <gerald.loacker@...fvision.net>

Regards,
Gerald