linux-kernel - Re: [PATCH 0/4] ASoC: use 'time_left' instead of 'timeout' with wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjNMPOOFg9myFSz3@opensource.cirrus.com>
Date: Thu, 2 May 2024 08:18:04 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
CC: <alsa-devel@...a-project.org>, Jaroslav Kysela <perex@...ex.cz>,
        "Liam
 Girdwood" <lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>,
        <linux-sound@...r.kernel.org>, Mark Brown <broonie@...nel.org>,
        <patches@...nsource.cirrus.com>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 0/4] ASoC: use 'time_left' instead of 'timeout' with
 wait_for_*() functions

On Tue, Apr 30, 2024 at 01:54:33PM +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_*() functions causing patterns like:
> 
>         timeout = wait_for_completion_timeout(...)
>         if (!timeout) return -ETIMEDOUT;
> 
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> obvious and self explaining.
> 
> This is part of a tree-wide series. The rest of the patches can be found here
> (some parts may still be WIP):
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left
> 
> Because these patches are generated, I audit them before sending. This is why I
> will send series step by step. Build bot is happy with these patches, though.
> No functional changes intended.
> 
> Wolfram Sang (4):
>   ASoC: codecs: wm8962: use 'time_left' variable with
>     wait_for_completion_timeout()
>   ASoC: codecs: wm8993: use 'time_left' variable with
>     wait_for_completion_timeout()
>   ASoC: codecs: wm8994: use 'time_left' variable with
>     wait_for_completion_timeout()
>   ASoC: codecs: wm8996: use 'time_left' variable with
>     wait_for_completion_timeout()
> 
>  sound/soc/codecs/wm8962.c | 12 ++++++------
>  sound/soc/codecs/wm8993.c | 12 ++++++------
>  sound/soc/codecs/wm8994.c |  8 ++++----
>  sound/soc/codecs/wm8996.c | 14 +++++++-------
>  4 files changed, 23 insertions(+), 23 deletions(-)
> 

All look good to me.

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles