linux-kernel - Re: [PATCH 1/2] staging: pi433: Use class_create instead of class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9efb9bdf-6f79-486b-ac18-3cf501aeef82@gmail.com>
Date: Thu, 2 May 2024 11:51:33 +0300
From: Shahar Avidar <ikobh7@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>,
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: hverkuil-cisco@...all.nl, andriy.shevchenko@...ux.intel.com,
 robh@...nel.org, felixkimbu1@...il.com, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: pi433: Use class_create instead of
 class_register.

On 01/05/2024 17:14, Greg KH wrote:
> On Wed, May 01, 2024 at 05:00:44PM +0300, Dan Carpenter wrote:
>> On Wed, May 01, 2024 at 08:58:19AM +0300, Shahar Avidar wrote:
>>> Make use of a higher level API.
>>> Reduce global memory allocation from struct class to pointer size.
>>
>> Doesn't this move the memory in the opposite direction from what we
>> want?  Originally, it's static const.  Isn't that the simplest best
>> kind of memory?
> 
> Our reviews just crossed...  This is just a revert (in 2 steps oddly),
> of a previous commit that changed this api call, and for that reason
> alone we can't take it :)
> 
Thank you for your input.
I replied to Greg's review on another thread.
I won't pursue this change.

-- 
Regards,

Shahar