linux-kernel - Re: [PATCH v4 11/12] mm: drop page_index and convert folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7636ada9-fdf0-4796-ab83-9ac60a213465@redhat.com>
Date: Thu, 2 May 2024 11:12:02 +0200
From: David Hildenbrand <david@...hat.com>
To: Kairui Song <kasong@...cent.com>, linux-mm@...ck.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 "Huang, Ying" <ying.huang@...el.com>, Matthew Wilcox <willy@...radead.org>,
 Chris Li <chrisl@...nel.org>, Barry Song <v-songbaohua@...o.com>,
 Ryan Roberts <ryan.roberts@....com>, Neil Brown <neilb@...e.de>,
 Minchan Kim <minchan@...nel.org>, Hugh Dickins <hughd@...gle.com>,
 Yosry Ahmed <yosryahmed@...gle.com>, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 11/12] mm: drop page_index and convert folio_index to
 use folio

On 02.05.24 10:49, Kairui Song wrote:
> From: Kairui Song <kasong@...cent.com>
> 
> There are two helpers for retrieving the index within address space
> for mixed usage of swap cache and page cache:
> 
> - page_index
> - folio_index (wrapper of page_index)
> 
> This commit drops page_index, as we have eliminated all users, and
> converts folio_index to use folio internally.

The latter does not make sense. folio_index() already is using a folio 
internally. Maybe a leftover from reshuffling/reworking patches?

-- 
Cheers,

David / dhildenb