linux-kernel - Re: [PATCH v5 18/18] arm64: dts: mediatek: mt8186-corsola: Specify sound DAI links and routing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXv+5GddLeYr-CZBFUcpUMR_NV0=0fu6Qp71hvKO6tJdJjF6w@mail.gmail.com>
Date: Thu, 2 May 2024 17:59:27 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: broonie@...nel.org, lgirdwood@...il.com, robh@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	matthias.bgg@...il.com, perex@...ex.cz, tiwai@...e.com, 
	trevor.wu@...iatek.com, maso.huang@...iatek.com, 
	xiazhengqiao@...qin.corp-partner.google.com, arnd@...db.de, 
	kuninori.morimoto.gx@...esas.com, shraash@...gle.com, amergnat@...libre.com, 
	nicolas.ferre@...rochip.com, u.kleine-koenig@...gutronix.de, 
	dianders@...omium.org, frank.li@...o.com, allen-kh.cheng@...iatek.com, 
	eugen.hristev@...labora.com, claudiu.beznea@...on.dev, 
	jarkko.nikula@...mer.com, jiaxin.yu@...iatek.com, alpernebiyasak@...il.com, 
	ckeepax@...nsource.cirrus.com, zhourui@...qin.corp-partner.google.com, 
	nfraprado@...labora.com, alsa-devel@...a-project.org, 
	shane.chien@...iatek.com, linux-sound@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
	kernel@...labora.com
Subject: Re: [PATCH v5 18/18] arm64: dts: mediatek: mt8186-corsola: Specify
 sound DAI links and routing

On Tue, Apr 16, 2024 at 3:15 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> The drivers and bindings acquired support for specifying audio hardware
> and links in device tree: describe and link the sound related HW of this
> machine.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  .../boot/dts/mediatek/mt8186-corsola.dtsi     | 42 ++++++++++++++++---
>  1 file changed, 37 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> index 1807e9d6cb0e..afdab5724eaa 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> @@ -42,7 +42,7 @@ backlight_lcd0: backlight-lcd0 {
>                 default-brightness-level = <576>;
>         };
>
> -       bt-sco-codec {
> +       bt-sco {

I remember changing this node from "bt-sco" to "bt-sco-codec" because
of a review comment when I submitted the Corsola dts series.

>                 compatible = "linux,bt-sco";
>                 #sound-dai-cells = <0>;
>         };
> @@ -223,12 +223,44 @@ sound: sound {
>                 mediatek,adsp = <&adsp>;
>                 mediatek,platform = <&afe>;
>
> -               playback-codecs {
> -                       sound-dai = <&it6505dptx>, <&rt1019p>;
> +               audio-routing =
> +                       "Headphone", "HPOL",
> +                       "Headphone", "HPOR",
> +                       "IN1P", "Headset Mic",
> +                       "Speakers", "Speaker",
> +                       "HDMI1", "TX";
> +
> +               hs-playback-dai-link {
> +                       link-name = "I2S0";
> +                       dai-format = "i2s";
> +                       mediatek,clk-provider = "cpu";
> +                       codec {
> +                               sound-dai = <&rt5682s 0>;
> +                       };
> +               };
> +
> +               hs-capture-dai-link {
> +                       link-name = "I2S1";
> +                       dai-format = "i2s";
> +                       mediatek,clk-provider = "cpu";
> +                       codec {
> +                               sound-dai = <&rt5682s 0>;
> +                       };
>                 };
>
> -               headset-codec {
> -                       sound-dai = <&rt5682s 0>;
> +               spk-share-dai-link {
> +                       link-name = "I2S2";
> +                       mediatek,clk-provider = "cpu";
> +               };
> +
> +               spk-hdmi-playback-dai-link {
> +                       link-name = "I2S3";
> +                       dai-format = "i2s";
> +                       mediatek,clk-provider = "cpu";
> +                       /* RT1019P and IT6505 connected to the same I2S line */
> +                       codec {
> +                               sound-dai = <&it6505dptx>, <&rt1019p>;
> +                       };
>                 };
>         };
>
> --
> 2.44.0
>