linux-kernel - Re: [PATCH 1/1] media: ipu6: Fix vmalloc memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240502110335.7b3495ab@sal.lan>
Date: Thu, 2 May 2024 11:03:35 +0100
From: Mauro Carvalho Chehab <mchehab@...nel.org>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>, linux-media@...r.kernel.org,
 Bingbu Cao <bingbu.cao@...el.com>, Hans Verkuil <hverkuil-cisco@...all.nl>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Next
 Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH 1/1] media: ipu6: Fix vmalloc memory allocation

Em Thu,  2 May 2024 09:15:25 +0300
Sakari Ailus <sakari.ailus@...ux.intel.com> escreveu:

> The driver was calling vmalloc() to allocate memory, something which isn't
> available except when particular Kconfig settings are enabled.
> 
> Use kvmalloc() instead.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> ---
> Hi Stephen,
> 
> Thanks for reporting this. I'm a bit surprised this wasn't catched
> earlier. But it seems vmalloc() is defined in some configuration.
> 
> - Sakari
> 
>  drivers/media/pci/intel/ipu6/ipu6.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
> index 4b1f69d14d71..082b1d6196be 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> @@ -526,7 +526,7 @@ static int request_cpd_fw(const struct firmware **firmware_p, const char *name,
>  	}
>  
>  	dst->size = fw->size;
> -	dst->data = vmalloc(fw->size);
> +	dst->data = kvmalloc(fw->size, GFP_KERNEL);

Where are you freeing it? If I understood the code right, you're storing
dst at isp->cpd_fw, but I can't see any code freeing it nor cpw_fw->data
at device removal.

Also, there is a logic there at the same function checking for vmalloc:

	if (is_vmalloc_addr(fw->data)) {
		*firmware_p = fw;
		return 0;
	}

As now the memory may not be inside vmalloc space, shouldn't this
be changed as well?

Regards,
Mauro

>  	if (!dst->data) {
>  		kfree(dst);
>  		ret = -ENOMEM;