linux-kernel - Re: [PATCH v4 02/12] nilfs2: drop usage of page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKFNMom8pX4J3EzgOzpJuU1Q9r6eHLNY4Dn3TOnya4K_2XWK_w@mail.gmail.com>
Date: Thu, 2 May 2024 20:08:52 +0900
From: Ryusuke Konishi <konishi.ryusuke@...il.com>
To: Kairui Song <kasong@...cent.com>
Cc: Matthew Wilcox <willy@...radead.org>, linux-mm@...ck.org, 
	Andrew Morton <akpm@...ux-foundation.org>, "Huang, Ying" <ying.huang@...el.com>, 
	Chris Li <chrisl@...nel.org>, Barry Song <v-songbaohua@...o.com>, 
	Ryan Roberts <ryan.roberts@....com>, Neil Brown <neilb@...e.de>, Minchan Kim <minchan@...nel.org>, 
	Hugh Dickins <hughd@...gle.com>, David Hildenbrand <david@...hat.com>, Yosry Ahmed <yosryahmed@...gle.com>, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-nilfs@...r.kernel.org
Subject: Re: [PATCH v4 02/12] nilfs2: drop usage of page_index

On Thu, May 2, 2024 at 5:47 PM Kairui Song wrote:
>
> From: Kairui Song <kasong@...cent.com>
>
> page_index is only for mixed usage of page cache and swap cache, for
> pure page cache usage, the caller can just use page->index instead.
>
> It can't be a swap cache page here (being part of buffer head),
> so just drop it. And while we are at it, optimize the code by retrieving
> the offset of the buffer head within the folio directly using bh_offset,
> and get rid of the loop and usage of page helpers.
>
> Suggested-by: Matthew Wilcox <willy@...radead.org>
> Signed-off-by: Kairui Song <kasong@...cent.com>
> Cc: Ryusuke Konishi <konishi.ryusuke@...il.com>
> Cc: linux-nilfs@...r.kernel.org
> ---
>  fs/nilfs2/bmap.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c
> index 383f0afa2cea..cd14ea25968c 100644
> --- a/fs/nilfs2/bmap.c
> +++ b/fs/nilfs2/bmap.c
> @@ -450,15 +450,9 @@ int nilfs_bmap_test_and_clear_dirty(struct nilfs_bmap *bmap)
>  __u64 nilfs_bmap_data_get_key(const struct nilfs_bmap *bmap,
>                               const struct buffer_head *bh)
>  {
> -       struct buffer_head *pbh;
> -       __u64 key;
> +       loff_t pos = folio_pos(bh->b_folio) + bh_offset(bh);
>
> -       key = page_index(bh->b_page) << (PAGE_SHIFT -
> -                                        bmap->b_inode->i_blkbits);
> -       for (pbh = page_buffers(bh->b_page); pbh != bh; pbh = pbh->b_this_page)
> -               key++;
> -
> -       return key;
> +       return pos >> bmap->b_inode->i_blkbits;
>  }
>
>  __u64 nilfs_bmap_find_target_seq(const struct nilfs_bmap *bmap, __u64 key)
> --
> 2.44.0

Looks good.  Feel free to add:

Acked-by: Ryusuke Konishi <konishi.ryusuke@...il.com>

Just to be sure, I also tested this change in different environments,
including 4k (page size) and smaller block sizes.  And of course it's
working as expected and so far hasn't broken anything.

Thanks,
Ryusuke Konishi