[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <203b39b1-fd83-4fc6-9d55-004d998494f2@suse.cz>
Date: Thu, 2 May 2024 14:23:21 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: linke li <lilinke99@...com>
Cc: xujianhao01@...il.com, Christoph Lameter <cl@...ux.com>,
Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>,
Joonsoo Kim <iamjoonsoo.kim@....com>,
Andrew Morton <akpm@...ux-foundation.org>,
Roman Gushchin <roman.gushchin@...ux.dev>,
Hyeonggon Yoo <42.hyeyoo@...il.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/slub: mark racy access on slab->freelist
On 4/27/24 10:51, linke li wrote:
> In deactivate_slab(), slab->freelist can be changed concurrently. Mark
> data race on slab->freelist as benign using READ_ONCE.
>
> This patch is aimed at reducing the number of benign races reported by
> KCSAN in order to focus future debugging effort on harmful races.
>
> Signed-off-by: linke li <lilinke99@...com>
Added to slab/for-6.10, thanks
> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 0d700f6ca547..bb0e05a321e9 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2813,7 +2813,7 @@ static void deactivate_slab(struct kmem_cache *s, struct slab *slab,
> struct slab new;
> struct slab old;
>
> - if (slab->freelist) {
> + if (READ_ONCE(slab->freelist)) {
> stat(s, DEACTIVATE_REMOTE_FREES);
> tail = DEACTIVATE_TO_TAIL;
> }
Powered by blists - more mailing lists