linux-kernel - Re: [PATCH v3 7/9] selftests/pidfd: Fix wrong expectation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240502-leiden-wegnehmen-9ac8f35c7204@brauner>
Date: Thu, 2 May 2024 16:12:28 +0200
From: Christian Brauner <brauner@...nel.org>
To: Mickaël Salaün <mic@...ikod.net>
Cc: Jakub Kicinski <kuba@...nel.org>, Kees Cook <keescook@...omium.org>, 
	Mark Brown <broonie@...nel.org>, Shengyu Li <shengyu.li.evgeny@...il.com>, 
	Shuah Khan <shuah@...nel.org>, "David S . Miller" <davem@...emloft.net>, 
	Günther Noack <gnoack@...gle.com>, Will Drewry <wad@...omium.org>, 
	kernel test robot <oliver.sang@...el.com>, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3 7/9] selftests/pidfd: Fix wrong expectation

On Mon, Apr 29, 2024 at 09:19:09PM +0200, Mickaël Salaün wrote:
> Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
> which will be actually tested on the parent and child sides with a
> following commit.
> 
> Cc: Christian Brauner <brauner@...nel.org>
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Reviewed-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>
> Link: https://lore.kernel.org/r/20240429191911.2552580-8-mic@digikod.net
> ---

Looks good to me,
Reviewed-by: Christian Brauner <brauner@...nel.org>