| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240502155626.GD15807@pendragon.ideasonboard.com> Date: Thu, 2 May 2024 18:56:26 +0300 From: Laurent Pinchart <laurent.pinchart@...asonboard.com> To: Julien Massot <julien.massot@...labora.com> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, Jacopo Mondi <jacopo+renesas@...ndi.org>, Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, Niklas Söderlund <niklas.soderlund+renesas@...natech.se>, Benjamin Mugnier <benjamin.mugnier@...s.st.com>, Sylvain Petinot <sylvain.petinot@...s.st.com>, Yong Zhi <yong.zhi@...el.com>, Bingbu Cao <bingbu.cao@...el.com>, Dan Scally <djrscally@...il.com>, Tianshu Qiu <tian.shu.qiu@...el.com>, Eugen Hristev <eugen.hristev@...labora.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>, Maxime Ripard <mripard@...nel.org>, Rui Miguel Silva <rmfrfs@...il.com>, Martin Kepplinger <martink@...teo.de>, Purism Kernel Team <kernel@...i.sm>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>, Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, Fabrizio Castro <fabrizio.castro.jz@...esas.com>, Dafna Hirschfeld <dafna@...tmail.com>, Heiko Stuebner <heiko@...ech.de>, Sylwester Nawrocki <s.nawrocki@...sung.com>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Alim Akhtar <alim.akhtar@...sung.com>, Hugues Fruchet <hugues.fruchet@...s.st.com>, Alain Volmat <alain.volmat@...s.st.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, Yong Deng <yong.deng@...ewell.com>, Paul Kocialkowski <paul.kocialkowski@...tlin.com>, Benoit Parrot <bparrot@...com>, Jai Luthra <j-luthra@...com>, Philipp Zabel <p.zabel@...gutronix.de>, Michal Simek <michal.simek@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Sowjanya Komatineni <skomatineni@...dia.com>, Luca Ceresoli <luca.ceresoli@...tlin.com>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev, linux-arm-msm@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-sunxi@...ts.linux.dev, linux-staging@...ts.linux.dev, linux-tegra@...r.kernel.org Subject: Re: [PATCH 0/2] Introduce v4l2_async_nf_unregister_cleanup Hi Julien, On Thu, May 02, 2024 at 05:22:20PM +0200, Julien Massot wrote: > Many drivers has > v4l2_async_nf_unregister(¬ifier); > v4l2_async_nf_cleanup(¬ifier); > > Introduce a helper function to call both functions in one line. Does this really go in the right direction ? For other objects (video devices, media devices, ...), the unregistration should be done at remove() time, and the cleanup at .release() time (the operation called when the last reference to the object is released). This is needed to ensure proper lifetime management of the objects, and avoid a use-after-free for objects that can be reached from userspace. It could be argued that the notifier isn't exposed to userspace, but can we guarantee that no driver will have a need to access the notifier in a code path triggered by a userspace operation ? I think it would be safer to adopt the same split for the nofifier unregistration and cleanup. In my opinion using the same rule across different APIs also make it easier for driver authors and for reviewers to get it right. As shown by your series, lots of drivers call v4l2_async_nf_cleanup() and .remove() time instead of .release(). That's because most drivers get lifetime management wrong and don't even implement .release(). That's something Sakari is addressing with ongoing work. This patch series seems to go in the opposite direction. > --- > Julien Massot (2): > media: v4l: async: Add v4l2_async_nf_unregister_cleanup > media: convert all drivers to use v4l2_async_nf_unregister_cleanup > > drivers/media/i2c/ds90ub913.c | 10 ++-------- > drivers/media/i2c/ds90ub953.c | 10 ++-------- > drivers/media/i2c/ds90ub960.c | 10 ++-------- > drivers/media/i2c/max9286.c | 3 +-- > drivers/media/i2c/st-mipid02.c | 6 ++---- > drivers/media/i2c/tc358746.c | 3 +-- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 6 ++---- > drivers/media/pci/intel/ipu6/ipu6-isys.c | 8 +------- > drivers/media/pci/intel/ivsc/mei_csi.c | 6 ++---- > drivers/media/platform/atmel/atmel-isi.c | 3 +-- > drivers/media/platform/cadence/cdns-csi2rx.c | 6 ++---- > drivers/media/platform/intel/pxa_camera.c | 3 +-- > drivers/media/platform/marvell/mcam-core.c | 6 ++---- > drivers/media/platform/microchip/microchip-csi2dc.c | 3 +-- > drivers/media/platform/microchip/microchip-isc-base.c | 6 ++---- > drivers/media/platform/nxp/imx-mipi-csis.c | 6 ++---- > drivers/media/platform/nxp/imx7-media-csi.c | 3 +-- > drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 3 +-- > drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 6 ++---- > drivers/media/platform/qcom/camss/camss.c | 3 +-- > drivers/media/platform/renesas/rcar-csi2.c | 6 ++---- > drivers/media/platform/renesas/rcar-isp.c | 6 ++---- > drivers/media/platform/renesas/rcar-vin/rcar-core.c | 9 +++------ > drivers/media/platform/renesas/rcar_drif.c | 3 +-- > drivers/media/platform/renesas/renesas-ceu.c | 4 +--- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 3 +-- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 6 ++---- > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 3 +-- > drivers/media/platform/samsung/exynos4-is/media-dev.c | 3 +-- > drivers/media/platform/st/stm32/stm32-dcmi.c | 3 +-- > .../media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 3 +-- > drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 3 +-- > .../media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c | 3 +-- > .../platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 3 +-- > .../sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c | 3 +-- > drivers/media/platform/ti/am437x/am437x-vpfe.c | 3 +-- > drivers/media/platform/ti/cal/cal.c | 8 +------- > drivers/media/platform/ti/davinci/vpif_capture.c | 3 +-- > drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 10 ++-------- > drivers/media/platform/ti/omap3isp/isp.c | 3 +-- > drivers/media/platform/video-mux.c | 3 +-- > drivers/media/platform/xilinx/xilinx-vipp.c | 3 +-- > drivers/staging/media/deprecated/atmel/atmel-isc-base.c | 6 ++---- > drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c | 3 +-- > drivers/staging/media/tegra-video/vi.c | 3 +-- > include/media/v4l2-async.h | 17 +++++++++++++++++ > 46 files changed, 80 insertions(+), 153 deletions(-) > --- > base-commit: 843a9f4a7a85988f2f3af98adf21797c2fd05ab1 > change-id: 20240502-master-5deee133b4f5 -- Regards, Laurent Pinchart
Powered by blists - more mailing lists