linux-kernel - Re: [PATCH 2/2] Input: ektf2127

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 2 May 2024 22:16:01 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Andreas Kemnade <andreas@...nade.info>
Cc: dmitry.torokhov@...il.com, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, hdegoede@...hat.com, u.kleine-koenig@...gutronix.de, 
	siebren.vroegindeweij@...mail.com, linux-input@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Input: ektf2127 - add ektf2232 support

On Thu, May 2, 2024 at 9:58 PM Andreas Kemnade <andreas@...nade.info> wrote:
>
> The chip is similar, but has status bits at different positions,
> so use the correct bits.

..

> +       if (ts->shifted_status) {
> +               ektf2127_report2_contact(ts, 0, &buf[1], !!(buf[7] & 1));
> +               ektf2127_report2_contact(ts, 1, &buf[4], !!(buf[7] & 2));

BIT(0)
BIT(1)

> +       } else {
> +               ektf2127_report2_contact(ts, 0, &buf[1], !!(buf[7] & 2));
> +               ektf2127_report2_contact(ts, 1, &buf[4], !!(buf[7] & 4));

BIT(1)
BIT(2)

> +       }

..

> +       if (dev->of_node &&
> +           of_device_is_compatible(dev->of_node, "elan,ektf2232"))

if (device_is_compatible(...))

> +               ts->shifted_status = true;

-- 
With Best Regards,
Andy Shevchenko