linux-kernel - Re: [PATCH v0 04/14] media: au0828: Make I2C terminology more inclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240503200314.51e8439a@sal.lan>
Date: Fri, 3 May 2024 20:03:14 +0100
From: Mauro Carvalho Chehab <mchehab@...nel.org>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: linux-media@...r.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE
 (V4L/DVB)), linux-kernel@...r.kernel.org (open list), Wolfram Sang
 <wsa+renesas@...g-engineering.com>, amd-gfx@...ts.freedesktop.org (open
 list:RADEON and AMDGPU DRM DRIVERS), dri-devel@...ts.freedesktop.org (open
 list:DRM DRIVERS), intel-gfx@...ts.freedesktop.org (open list:INTEL DRM
 DISPLAY FOR XE AND I915 DRIVERS), intel-xe@...ts.freedesktop.org (open
 list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS),
 nouveau@...ts.freedesktop.org (open list:DRM DRIVER FOR NVIDIA
 GEFORCE/QUADRO GPUS), linux-i2c@...r.kernel.org (open list:I2C SUBSYSTEM
 HOST DRIVERS), linux-fbdev@...r.kernel.org (open list:FRAMEBUFFER LAYER)
Subject: Re: [PATCH v0 04/14] media: au0828: Make I2C terminology more
 inclusive

Em Fri, 29 Mar 2024 17:00:28 +0000
Easwar Hariharan <eahariha@...ux.microsoft.com> escreveu:

> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave"
> with more appropriate terms. Inspired by and following on to Wolfram's
> series to fix drivers/i2c/[1], fix the terminology for users of
> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> in the specification.
> 
> Compile tested, no functionality changes intended

Current media drivers are perfectly fine with the current terminology. 
None of them implement the above new standards.

Please drop patches for current stuff under drivers/media.

Regards,
Mauro

> 
> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
> 
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> ---
>  drivers/media/usb/au0828/au0828-i2c.c   | 4 ++--
>  drivers/media/usb/au0828/au0828-input.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/usb/au0828/au0828-i2c.c b/drivers/media/usb/au0828/au0828-i2c.c
> index 749f90d73b5b..3e66d42bf134 100644
> --- a/drivers/media/usb/au0828/au0828-i2c.c
> +++ b/drivers/media/usb/au0828/au0828-i2c.c
> @@ -23,7 +23,7 @@ MODULE_PARM_DESC(i2c_scan, "scan i2c bus at insmod time");
>  #define I2C_WAIT_DELAY 25
>  #define I2C_WAIT_RETRY 1000
>  
> -static inline int i2c_slave_did_read_ack(struct i2c_adapter *i2c_adap)
> +static inline int i2c_client_did_read_ack(struct i2c_adapter *i2c_adap)
>  {
>  	struct au0828_dev *dev = i2c_adap->algo_data;
>  	return au0828_read(dev, AU0828_I2C_STATUS_201) &
> @@ -35,7 +35,7 @@ static int i2c_wait_read_ack(struct i2c_adapter *i2c_adap)
>  	int count;
>  
>  	for (count = 0; count < I2C_WAIT_RETRY; count++) {
> -		if (!i2c_slave_did_read_ack(i2c_adap))
> +		if (!i2c_client_did_read_ack(i2c_adap))
>  			break;
>  		udelay(I2C_WAIT_DELAY);
>  	}
> diff --git a/drivers/media/usb/au0828/au0828-input.c b/drivers/media/usb/au0828/au0828-input.c
> index 3d3368202cd0..98a57b6e02e2 100644
> --- a/drivers/media/usb/au0828/au0828-input.c
> +++ b/drivers/media/usb/au0828/au0828-input.c
> @@ -30,7 +30,7 @@ struct au0828_rc {
>  	int polling;
>  	struct delayed_work work;
>  
> -	/* i2c slave address of external device (if used) */
> +	/* i2c client address of external device (if used) */
>  	u16 i2c_dev_addr;
>  
>  	int  (*get_key_i2c)(struct au0828_rc *ir);