linux-kernel - Re: [PATCH 4/4] selftests/cgroup: fix uninitialized variables in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKEwX=OzV+hCXwwFhnAWKvsrDq_vMaS6GaJgRn8LG_EsB80OCw@mail.gmail.com>
Date: Fri, 3 May 2024 12:50:28 -0700
From: Nhat Pham <nphamcs@...il.com>
To: John Hubbard <jhubbard@...dia.com>
Cc: Shuah Khan <shuah@...nel.org>, Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>, 
	Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...nel.org>, 
	Roman Gushchin <roman.gushchin@...ux.dev>, Shakeel Butt <shakeel.butt@...ux.dev>, 
	Muchun Song <muchun.song@...ux.dev>, Waiman Long <longman@...hat.com>, 
	Yosry Ahmed <yosryahmed@...gle.com>, Chengming Zhou <chengming.zhou@...ux.dev>, 
	Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org, 
	cgroups@...r.kernel.org, linux-mm@...ck.org, 
	LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH 4/4] selftests/cgroup: fix uninitialized variables in test_zswap.c

On Thu, May 2, 2024 at 8:51 PM John Hubbard <jhubbard@...dia.com> wrote:
>
> First of all, in order to build with clang at all, one must first apply
> Valentin Obst's build fix for LLVM [1]. Once that is done, then when
> building with clang, via:
>
>     make LLVM=1 -C tools/testing/selftests
>
> ...clang finds and warning about some uninitialized variables. Fix these
> by initializing them.
>
> [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>

Reviewed-by: Nhat Pham <nphamcs@...il.com>
> ---