linux-kernel - Re: [PATCH 3/6] dt-bindings: mips: brcm: Document mips-cbr-reg property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74d7601c-ba89-42c3-acfa-31d55cf04e0e@broadcom.com>
Date: Fri, 3 May 2024 13:06:12 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Christian Marangi <ansuelsmth@...il.com>, Conor Dooley <conor@...nel.org>
Cc: Hauke Mehrtens <hauke@...ke-m.de>, Rafał Miłecki
 <zajec5@...il.com>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Álvaro Fernández Rojas <noltari@...il.com>,
 linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Daniel González Cabanelas
 <dgcbueu@...il.com>
Subject: Re: [PATCH 3/6] dt-bindings: mips: brcm: Document mips-cbr-reg
 property

On 5/3/24 12:33, Christian Marangi wrote:
> On Fri, May 03, 2024 at 05:21:41PM +0100, Conor Dooley wrote:
>> On Fri, May 03, 2024 at 03:54:03PM +0200, Christian Marangi wrote:
>>> Document mips-cbr-reg and mips-broken-cbr-reg property.
>>>
>>> Some SoC suffer from a BUG where read_c0_brcm_cbr() might return 0
>>> if called from TP1. The CBR address is always the same on the SoC
>>> hence it can be provided in DT to handle broken case where bootloader
>>> doesn't init it or SMP where read_c0_brcm_cbr() returns 0 from TP1.
>>>
>>> Usage of this property is to give an address also in these broken
>>> configuration/bootloader.
>>>
>>> If the SoC/Bootloader ALWAYS provide a broken CBR address the property
>>> "mips-broken-cbr-reg" can be used to ignore any value already set in the
>>> registers for CBR address.
>>>
>>> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
>>> ---
>>>   .../devicetree/bindings/mips/brcm/soc.yaml    | 32 +++++++++++++++++++
>>>   1 file changed, 32 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.yaml b/Documentation/devicetree/bindings/mips/brcm/soc.yaml
>>> index 975945ca2888..12d394b7e011 100644
>>> --- a/Documentation/devicetree/bindings/mips/brcm/soc.yaml
>>> +++ b/Documentation/devicetree/bindings/mips/brcm/soc.yaml
>>> @@ -55,6 +55,21 @@ properties:
>>>            under the "cpus" node.
>>>           $ref: /schemas/types.yaml#/definitions/uint32
>>>   
>>> +      mips-broken-cbr-reg:
>>> +        description: Declare that the Bootloader init a broken
>>> +          CBR address in the registers and the one provided from
>>> +          DT should always be used.
>>
>> Why is this property even needed, is it not sufficient to just add the
>> mips-cbr-reg property to the DT for SoCs that need it and use the
>> property when present?
>>
> 
> I described this in the cover letter. CBR might be set by the Bootloader
> and might be not 0. In that case the value is ignored as an extra
> precaution and the broken propetry is needed.
> 
>>> +        type: boolean
>>> +
>>> +      mips-cbr-reg:
>>
>> Missing a vendor prefix.
>>
> 
> I will change this to bmips,cbr-reg hope it's O.K.

brcm,bmips-cbr-reg please.
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)