linux-kernel - Re: [PATCH] crypto: iaa - Use kmemdup() instead of kzalloc() and memcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7da2bc1a966061aa11110f7e0304d82dfaa322e8.camel@linux.intel.com>
Date: Fri, 03 May 2024 15:32:52 -0500
From: Tom Zanussi <tom.zanussi@...ux.intel.com>
To: Thorsten Blum <thorsten.blum@...lux.com>, Herbert Xu
	 <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: iaa - Use kmemdup() instead of kzalloc() and
 memcpy()

Hi Thorsten,

On Thu, 2024-05-02 at 17:33 +0200, Thorsten Blum wrote:
> Fixes the following two Coccinelle/coccicheck warnings reported by
> memdup.cocci:
> 
>         iaa_crypto_main.c:350:19-26: WARNING opportunity for kmemdup
>         iaa_crypto_main.c:358:18-25: WARNING opportunity for kmemdup
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  drivers/crypto/intel/iaa/iaa_crypto_main.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> index b2191ade9011..7635fbebe52f 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> @@ -347,18 +347,16 @@ int add_iaa_compression_mode(const char *name,
>                 goto free;
>  
>         if (ll_table) {
> -               mode->ll_table = kzalloc(ll_table_size, GFP_KERNEL);
> +               mode->ll_table = kmemdup(ll_table, ll_table_size, GFP_KERNEL);
>                 if (!mode->ll_table)
>                         goto free;
> -               memcpy(mode->ll_table, ll_table, ll_table_size);
>                 mode->ll_table_size = ll_table_size;
>         }
>  
>         if (d_table) {
> -               mode->d_table = kzalloc(d_table_size, GFP_KERNEL);
> +               mode->d_table = kmemdup(d_table, d_table_size, GFP_KERNEL);
>                 if (!mode->d_table)
>                         goto free;
> -               memcpy(mode->d_table, d_table, d_table_size);
>                 mode->d_table_size = d_table_size;
>         }
>  

Looks good, thanks for the cleanup.

Reviewed-by: Tom Zanussi <tom.zanussi@...ux.intel.com>