linux-kernel - Re: [PATCH] drm/msm/gen_header: allow skipping the validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xtnfj6foaxy6upqydlozrm4bbg4cawjecuuud6szbgtpjitvag@fpc5bmpptelk>
Date: Fri, 3 May 2024 23:58:30 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Rob Clark <robdclark@...il.com>, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Sean Paul <sean@...rly.run>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, 
	Daniel Vetter <daniel@...ll.ch>, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] drm/msm/gen_header: allow skipping the validation

On Fri, May 03, 2024 at 09:48:12AM -0700, Nathan Chancellor wrote:
> Hi Dmitry,
> 
> On Tue, Apr 09, 2024 at 05:22:54PM +0300, Dmitry Baryshkov wrote:
> > We don't need to run the validation of the XML files if we are just
> > compiling the kernel. Skip the validation unless the user enables
> > corresponding Kconfig option. This removes a warning from gen_header.py
> > about lxml being not installed.
> > 
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Closes: https://lore.kernel.org/all/20240409120108.2303d0bd@canb.auug.org.au/
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > ---
> >  drivers/gpu/drm/msm/Kconfig                 |  8 ++++++++
> >  drivers/gpu/drm/msm/Makefile                |  9 ++++++++-
> >  drivers/gpu/drm/msm/registers/gen_header.py | 14 +++++++++++---
> >  3 files changed, 27 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> > index f202f26adab2..4c9bf237d4a2 100644
> > --- a/drivers/gpu/drm/msm/Kconfig
> > +++ b/drivers/gpu/drm/msm/Kconfig
> > @@ -54,6 +54,14 @@ config DRM_MSM_GPU_SUDO
> >  	  Only use this if you are a driver developer.  This should *not*
> >  	  be enabled for production kernels.  If unsure, say N.
> >  
> > +config DRM_MSM_VALIDATE_XML
> > +	bool "Validate XML register files against schema"
> > +	depends on DRM_MSM && EXPERT
> > +	depends on $(success,$(PYTHON3) -c "import lxml")
> > +	help
> > +	  Validate XML files with register definitions against rules-fd schema.
> > +	  This option is mostly targeting DRM MSM developers. If unsure, say N.
> 
> Is this change going to be applied? I have gotten a little tired of
> seeing "lxml not found, skipping validation" in all of my builds :)
> 
I've posted v2, including CI changes. The plan is to get it merged
before the drm/msm pull request.

-- 
With best wishes
Dmitry