linux-kernel - Re: [PATCH] arm64: dts: imx8qm: Add GPU nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 2 May 2024 23:05:39 -0400
From: Frank Li <Frank.li@....com>
To: Fabio Estevam <festevam@...il.com>
Cc: Christian Gmeiner <christian.gmeiner@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Christian Gmeiner <cgmeiner@...lia.com>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8qm: Add GPU nodes

On Thu, May 02, 2024 at 08:01:37PM -0300, Fabio Estevam wrote:
> Hi Christian,
> 
> On Thu, May 2, 2024 at 6:58 PM Christian Gmeiner
> <christian.gmeiner@...il.com> wrote:
> >
> > From: Christian Gmeiner <cgmeiner@...lia.com>
> >
> > Add the DT node for the GPU core found on the i.MX8QM.
> >
> > etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
> > [drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0
> >
> > Signed-off-by: Christian Gmeiner <cgmeiner@...lia.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > index b3d01677b70c..54879ae1d7d5 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > @@ -467,6 +467,7 @@ drc_crit0: trip1 {
> >         #include "imx8-ss-dma.dtsi"
> >         #include "imx8-ss-conn.dtsi"
> >         #include "imx8-ss-lsio.dtsi"
> > +       #include "imx8-ss-gpu0.dtsi"
> 
> Nit: better put it in alphabetical order.

No, it should be order by subsystem register address. gpu is 53100000.
should be between imx8-ss-vpu and imx8-ss-img. 

Frank

> 
> Reviewed-by: Fabio Estevam <festevam@...il.com>