linux-kernel - Re: [PATCH] x86: Code cleanup for ehci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240503221254.GA1607085@bhelgaas>
Date: Fri, 3 May 2024 17:12:54 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Kunwu Chan <chentao@...inos.cn>
Cc: bhelgaas@...gle.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
	dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andres Salomon <dilinger@...ued.net>
Subject: Re: [PATCH] x86: Code cleanup for ehci_hdr

[+cc Andres, author of 3ef0e1f8cad0]

On Thu, Jan 25, 2024 at 11:06:23AM +0800, Kunwu Chan wrote:
> This part was commented from commit 3ef0e1f8cad0
> ("x86: olpc: add One Laptop Per Child architecture support")
> in about 16 years before.
> 
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
> 
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>

Applied to pci/misc for v6.10, thanks.

> ---
>  arch/x86/pci/olpc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/pci/olpc.c b/arch/x86/pci/olpc.c
> index f3aab76e357a..4b18c6404363 100644
> --- a/arch/x86/pci/olpc.c
> +++ b/arch/x86/pci/olpc.c
> @@ -154,9 +154,6 @@ static const uint32_t ehci_hdr[] = {  /* dev f function 4 - devfn = 7d */
>  	0x0,	0x40,	0x0,	0x40a,			/* CapPtr INT-D, IRQA */
>  	0xc8020001, 0x0, 0x0,	0x0,	/* Capabilities - 40 is R/O, 44 is
>  					   mask 8103 (power control) */
> -#if 0
> -	0x1,	0x40080000, 0x0, 0x0,	/* EECP - see EHCI spec section 2.1.7 */
> -#endif
>  	0x01000001, 0x0, 0x0,	0x0,	/* EECP - see EHCI spec section 2.1.7 */
>  	0x2020,	0x0,	0x0,	0x0,	/* (EHCI page 8) 60 SBRN (R/O),
>  					   61 FLADJ (R/W), PORTWAKECAP  */
> -- 
> 2.39.2
>