linux-kernel - Re: [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to ax25_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89f07a73-90c6-4a81-9cec-7a1b7d61ea6b@web.de>
Date: Fri, 3 May 2024 07:36:54 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Duoming Zhou <duoming@....edu.cn>, linux-hams@...r.kernel.org,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Jörg Reuter
 <jreuter@...na.de>, Paolo Abeni <pabeni@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Lars Kellogg-Stedman <lars@...bit.com>
Subject: Re: [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to
 ax25_dev_free

> The ax25_dev is managed by reference counting, so it should not be
> deallocated directly by kfree() in ax25_dev_free(), replace it with
> ax25_dev_put() instead.

You repeated a wording mistake in the summary phrase from a previous cover letter.
Please avoid confusion about desired code replacements.
How do you think about to append parentheses to involved function names?

Would you find the following change description a bit nicer?

   The object “ax25_dev” is managed by reference counting.
   Thus it should not be directly released by a kfree() call in ax25_dev_free().
   Replace it with a ax25_dev_put() call instead.

Would you like to extend patch version descriptions (or changelogs) accordingly?

Regards,
Markus