linux-kernel - Re: [PATCH RFC v2 4/4] riscv: dts: thead: Add clock to TH1520 mmc controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a67700a-0f46-4336-95a0-2aacf40ce916@bootlin.com>
Date: Fri, 3 May 2024 08:58:35 +0200
From: Thomas Bonnefille <thomas.bonnefille@...tlin.com>
To: Drew Fustini <dfustini@...storrent.com>
Cc: Jisheng Zhang <jszhang@...nel.org>, Guo Ren <guoren@...nel.org>,
 Fu Wei <wefu@...hat.com>, Yangtao Li <frank.li@...o.com>,
 Emil Renner Berthing <emil.renner.berthing@...onical.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH RFC v2 4/4] riscv: dts: thead: Add clock to TH1520 mmc
 controllers



On 5/2/24 5:53 PM, Drew Fustini wrote:
> On Thu, May 02, 2024 at 09:47:43AM +0200, Thomas Bonnefille wrote:
>>
>>
>> On 4/27/24 2:10 AM, Drew Fustini wrote:
>>> Change the clock property in the T-Head TH1520 mmc controller nodes to a
>>> real clock provided by the AP_SUBSYS clock driver.
>>>
>>> Signed-off-by: Drew Fustini <dfustini@...storrent.com>
>>
>> I experienced that, when the I2C clocks were correctly configured, the UART
>> stopped working, likely due to their dependence on FOUTPOSTDIV.
>> Setting up the UART correctly, for instance:
>>
>>                  uartx: serial@...xxxxxxx {
>> 			...
>>                          clocks = <&clk CLK_UART_SCLK>, <&clk
>> CLK_UARTX_PCLK>;
>>                          clock-names = "baudclk", "apb_pclk";
>>                          ...
>> 			status = "disabled";
>>                  };
>> resolved the issue.
>> As this would be mandatory in the future, I suggest that you configure all
>> the nodes currently set to a fixed clock, not just the MMC controller.
> 
> Thank you for testing and discovering this issue.
> 
> Could you post your device tree so I can be sure I'm testing the same as
> what you have?
> 
> Drew

Of course, I'll attach the two Device Trees used.
Note that I also use Emil's patch which adds support for pinctrl.

Thomas
View attachment "th1520.dtsi" of type "text/x-devicetree-source" (14503 bytes)

Download attachment "th1520-beaglev-ahead.dts" of type "audio/vnd.dts" (4484 bytes)