linux-kernel - Re: [PATCH v9 1/3] soc: qcom: Add qcom_rproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 3 May 2024 13:57:29 +0530
From: Mukesh Ojha <quic_mojha@...cinc.com>
To: Bjorn Andersson <quic_bjorande@...cinc.com>
CC: <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <mathieu.poirier@...aro.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>
Subject: Re: [PATCH v9 1/3] soc: qcom: Add qcom_rproc_minidump module



On 4/30/2024 7:08 PM, Bjorn Andersson wrote:
> On Tue, Mar 26, 2024 at 07:43:12PM +0530, Mukesh Ojha wrote:
>> Add qcom_rproc_minidump module in a preparation to remove
>> minidump specific code from driver/remoteproc/qcom_common.c
>> and provide needed exported API, this as well helps to
>> abstract minidump specific data layout from qualcomm's
>> remoteproc driver.
>>
>> It is just a copying of qcom_minidump() functionality from
>> driver/remoteproc/qcom_common.c into a separate file under
>> qcom_rproc_minidump().
>>
> 
> I'd prefer to see this enter the git history as one patch, extracting
> this logic from the remoteproc into its own driver - rather than as
> presented here give a sense that it's a new thing added. (I'll take care
> of the maintainer sync...)
> 
> I also would prefer for this to include a problem description,
> documenting why this is done.
> 
> 
> I've not compared patch 1 and 3, but I'd also like a statement in the
> commit message telling if there are any changes, or if the functions are
> cleanly moved from one place to another.


Thanks for the review, addressed the comments here in v10.

https://lore.kernel.org/lkml/1714724287-12518-1-git-send-email-quic_mojha@quicinc.com/

-Mukesh