linux-kernel - Re: [PATCH 05/10] PCI: ixp4xx: Use generic PCI Conf Type 0 helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaG8CYoGbEa1AG0bByd-oTWcnfKChn2F1QsdnUHLkoX+g@mail.gmail.com>
Date: Fri, 3 May 2024 10:42:43 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] PCI: ixp4xx: Use generic PCI Conf Type 0 helper

On Mon, Apr 29, 2024 at 12:47 PM Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com> wrote:

> Convert Type 0 address calculation to use pci_conf0_offset() instead of
> abusing PCI_CONF1_ADDRESS().
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Looks better indeed.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij