linux-kernel - Re: [PATCH v3] hwmon (max6639): Use regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 3 May 2024 18:19:14 +0800
From: kernel test robot <lkp@...el.com>
To: Naresh Solanki <naresh.solanki@...ements.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>
Cc: oe-kbuild-all@...ts.linux.dev,
	Naresh Solanki <naresh.solanki@...ements.com>,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] hwmon (max6639): Use regmap

Hi Naresh,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 1d4d6733594d407e54153b8e031ba6356ceba81e]

url:    https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/hwmon-max6639-Use-regmap/20240503-024046
base:   1d4d6733594d407e54153b8e031ba6356ceba81e
patch link:    https://lore.kernel.org/r/20240502183604.1216576-1-naresh.solanki%409elements.com
patch subject: [PATCH v3] hwmon (max6639): Use regmap
config: i386-buildonly-randconfig-003-20240503 (https://download.01.org/0day-ci/archive/20240503/202405031504.sA1rmWDu-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240503/202405031504.sA1rmWDu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405031504.sA1rmWDu-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/hwmon/max6639.c: In function 'max6639_suspend':
>> drivers/hwmon/max6639.c:540:13: warning: unused variable 'ret' [-Wunused-variable]
     540 |         int ret;
         |             ^~~


vim +/ret +540 drivers/hwmon/max6639.c

   536	
   537	static int max6639_suspend(struct device *dev)
   538	{
   539		struct max6639_data *data = dev_get_drvdata(dev);
 > 540		int ret;
   541	
   542		if (data->reg)
   543			regulator_disable(data->reg);
   544	
   545		return regmap_write_bits(data->regmap, MAX6639_REG_GCONFIG, MAX6639_GCONFIG_STANDBY,
   546					 MAX6639_GCONFIG_STANDBY);
   547	}
   548	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki