linux-kernel - RE: [PATCH] scsi: ufs: Allow RTT negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB6575A1337E81A241CD37FCB1FC1F2@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Fri, 3 May 2024 10:43:56 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bean Huo <huobean@...il.com>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: Bart Van Assche <bvanassche@....org>, Bean Huo <beanhuo@...ron.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: Allow RTT negotiation

> Avri,
> 
> On 02.05.24 3:19 PM, Avri Altman wrote:
> > +     /* RTT override makes sense only for UFS-4.0 and above */
> > +     if (dev_info->wspecversion < 0x400)
> > +             return;
> > +
> > +     rtt = min_t(int, desc_buf[DEVICE_DESC_PARAM_RTT_CAP], hba->nortt);
> > +     /* rtt is 2 after manufacturing */
> > +     if (rtt < 3)
> > +             return;
> > +
> > +     if (ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
> > +                                 QUERY_ATTR_IDN_MAX_NUM_OF_RTT, 0, 0, &rtt))
> > +             dev_err(hba->dev, "failed writing bMaxNumOfRTT\n"); }
> 
> bMaxNumOfRTT is Persistent Property,  do we need to re-write every time
> power cycle?
Correct.
Moreover, don't want to override use-space should it was written.
Will fix.

Thanks,
Avri

> 
> Kind regards,
> 
> Bean
>