linux-kernel - Re: [PATCH v1 1/1] selftest mm/mseal: fix arm build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f90431c-f27d-4b59-bf5a-32fd66101230@arm.com>
Date: Fri, 3 May 2024 12:00:08 +0100
From: Ryan Roberts <ryan.roberts@....com>
To: jeffxu@...omium.org, Aishwarya TCV <Aishwarya.TCV@....com>
Cc: Liam.Howlett@...cle.com, akpm@...ux-foundation.org, corbet@....net,
 dave.hansen@...el.com, deraadt@...nbsd.org, gregkh@...uxfoundation.org,
 groeck@...omium.org, jannh@...gle.com, jeffxu@...gle.com,
 jorgelo@...omium.org, keescook@...omium.org,
 linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-mm@...ck.org, merimus@...gle.com,
 pedro.falcato@...il.com, rdunlap@...radead.org, sroettger@...gle.com,
 surenb@...gle.com, torvalds@...ux-foundation.org, usama.anjum@...labora.com,
 willy@...radead.org
Subject: Re: [PATCH v1 1/1] selftest mm/mseal: fix arm build

On 02/05/2024 23:53, jeffxu@...omium.org wrote:
> From: Jeff Xu <jeffxu@...omium.org>
> 
> add include linux/mman.h to fix arm build
> fix a typo
> 
> Signed-off-by: Jeff Xu <jeffxu@...omium.org>
> Suggested-by: Ryan Roberts <ryan.roberts@....com>

I confirm this has fixed our issue. Thanks!

Tested-by: Ryan Roberts <ryan.roberts@....com>
Reviewed-by: Ryan Roberts <ryan.roberts@....com>

> ---
>  tools/testing/selftests/mm/mseal_test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> index ca8dbee0c612..41998cf1dcf5 100644
> --- a/tools/testing/selftests/mm/mseal_test.c
> +++ b/tools/testing/selftests/mm/mseal_test.c
> @@ -1,5 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  #define _GNU_SOURCE
> +#include <linux/mman.h>
>  #include <sys/mman.h>
>  #include <stdint.h>
>  #include <unistd.h>
> @@ -29,7 +30,7 @@
>  # define PKEY_DISABLE_WRITE     0x2
>  #endif
>  
> -#ifndef PKEY_BITS_PER_KEY
> +#ifndef PKEY_BITS_PER_PKEY
>  #define PKEY_BITS_PER_PKEY      2
>  #endif
>