linux-kernel - Re: [PATCH v3] gpio: nuvoton: Fix sgpio irq handle error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87badb93-27d4-4255-8dde-24774d8e04c1@moroto.mountain>
Date: Fri, 3 May 2024 14:56:15 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Jim Liu <jim.t90615@...il.com>
Cc: JJLIU0@...oton.com, KWLIU@...oton.com, linus.walleij@...aro.org,
	brgl@...ev.pl, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH v3] gpio: nuvoton: Fix sgpio irq handle error

On Mon, Apr 29, 2024 at 03:05:23PM +0800, Jim Liu wrote:
> The generic_handle_domain_irq() function calls irq_resolve_mapping()
> so calling irq_find_mapping() is duplicative and will lead to a stack
> trace and an RCU stall.
> 
> 
> Fixes: c4f8457d17ce ("gpio: nuvoton: Add Nuvoton NPCM sgpio driver")
> Signed-off-by: Jim Liu <JJLIU0@...oton.com>
> ---
> Changes for v3:
>    - remove unused variable
> Changes for v2:
>    - add more description

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter