lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87bk5nayl2.wl-tiwai@suse.de>
Date: Fri, 03 May 2024 14:07:05 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Jaroslav Kysela <perex@...ex.cz>
Cc: Mark Brown <broonie@...nel.org>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"end.to.start" <end.to.start@...l.ru>,
	lgirdwood@...il.com,
	tiwai@...e.com
Subject: Re: [PATCH 1/1] sound: Support microphone from device Acer 315-24p

On Fri, 03 May 2024 13:23:28 +0200,
Jaroslav Kysela wrote:
> 
> On 09. 04. 24 20:08, Mark Brown wrote:
> > On Mon, 08 Apr 2024 18:24:54 +0300, end.to.start wrote:
> >> This patch adds microphone detection for the Acer 315-24p, after which a microphone appears on the device and starts working
> >> 
> >> 
> > 
> > Applied to
> > 
> >     https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> > 
> > Thanks!
> > 
> > [1/1] sound: Support microphone from device Acer 315-24p
> >        commit: 4b9a474c7c820391c0913d64431ae9e1f52a5143
> > 
> > All being well this means that it will be integrated into the linux-next
> > tree (usually sometime in the next 24 hours) and sent to Linus during
> > the next merge window (or sooner if it is a bug fix), however if
> > problems are discovered then the patch may be dropped or reverted.
> 
> Shall we really accept those anonymous contributions?
> 
> From submitting-patches.rst:
> 
> """
> then you just add a line saying::
> 
>         Signed-off-by: Random J Developer <random@...eloper.example.org>
> 
> using a known identity (sorry, no anonymous contributions.)
> """

Yeah, that's a bad example, and I noticed too late after sending a PR
to Linus, too (I concentrated only on the diffs).

The code change itself looks OK, so this is no big problem.
But let's decline such a submission at the next time.


thanks,

Takashi

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ