linux-kernel - RE: [PATCH v2 1/2] spi: spi-cadence: Add optional reset control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <ZQ4PR01MB11549D971962995878D9593EEB1FA@ZQ4PR01MB1154.CHNPR01.prod.partner.outlook.cn>
Date: Fri, 3 May 2024 01:20:46 +0000
From: JiSheng Teoh <jisheng.teoh@...rfivetech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Mark Brown <broonie@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
	Michal Simek <michal.simek@....com>, Lars-Peter Clausen <lars@...afoo.de>
CC: Leyfoon Tan <leyfoon.tan@...rfivetech.com>, "linux-spi@...r.kernel.org"
	<linux-spi@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, EngLee Teh <englee.teh@...rfivetech.com>
Subject: RE: [PATCH v2 1/2] spi: spi-cadence: Add optional reset control
 support

> On 02/05/2024 12:47, Ji Sheng Teoh wrote:
> >
> >  /* Macros for the SPI controller read/write */ @@ -588,6 +591,16 @@
> > static int cdns_spi_probe(struct platform_device *pdev)
> >  		goto remove_ctlr;
> >  	}
> >
> > +	xspi->rstc = devm_reset_control_get_optional_exclusive(&pdev->dev, "spi");
> > +	if (IS_ERR(xspi->rstc)) {
> > +		ret = PTR_ERR(xspi->rstc);
> > +		dev_err(&pdev->dev, "Cannot get SPI reset.\n");
> 
> Please switch to:
> ret = dev_err_probe()

Ok, will switch to that. Thanks.