linux-kernel - Re: [PATCH net-next v6 0/8] sysctl: Remove sentinel elements from networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240503122045.6uvwnijtem3sbcl5@joelS2.panther.com>
Date: Fri, 3 May 2024 14:20:45 +0200
From: Joel Granados <j.granados@...sung.com>
To: Sabrina Dubroca <sd@...asysnail.net>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Alexander Aring <alex.aring@...il.com>, Stefan Schmidt
	<stefan@...enfreihafen.org>, Miquel Raynal <miquel.raynal@...tlin.com>,
	David Ahern <dsahern@...nel.org>, Steffen Klassert
	<steffen.klassert@...unet.com>, Herbert Xu <herbert@...dor.apana.org.au>,
	Matthieu Baerts <matttbe@...nel.org>, Mat Martineau <martineau@...nel.org>,
	Geliang Tang <geliang@...nel.org>, Remi Denis-Courmont
	<courmisch@...il.com>, Allison Henderson <allison.henderson@...cle.com>,
	David Howells <dhowells@...hat.com>, Marc Dionne <marc.dionne@...istor.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Xin Long
	<lucien.xin@...il.com>, Wenjia Zhang <wenjia@...ux.ibm.com>, Jan Karcher
	<jaka@...ux.ibm.com>, "D. Wythe" <alibuda@...ux.alibaba.com>, Tony Lu
	<tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>, Trond
	Myklebust <trond.myklebust@...merspace.com>, Anna Schumaker
	<anna@...nel.org>, Chuck Lever <chuck.lever@...cle.com>, Jeff Layton
	<jlayton@...nel.org>, Neil Brown <neilb@...e.de>, Olga Kornievskaia
	<kolga@...app.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey
	<tom@...pey.com>, Jon Maloy <jmaloy@...hat.com>, Ying Xue
	<ying.xue@...driver.com>, Martin Schiller <ms@....tdt.de>, Pablo Neira Ayuso
	<pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...filter.org>, Florian
	Westphal <fw@...len.de>, Roopa Prabhu <roopa@...dia.com>, Nikolay
	Aleksandrov <razor@...ckwall.org>, Simon Horman <horms@...ge.net.au>, Julian
	Anastasov <ja@....bg>, Joerg Reuter <jreuter@...na.de>, Luis Chamberlain
	<mcgrof@...nel.org>, Kees Cook <keescook@...omium.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<dccp@...r.kernel.org>, <linux-wpan@...r.kernel.org>,
	<mptcp@...ts.linux.dev>, <linux-hams@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <rds-devel@....oracle.com>,
	<linux-afs@...ts.infradead.org>, <linux-sctp@...r.kernel.org>,
	<linux-s390@...r.kernel.org>, <linux-nfs@...r.kernel.org>,
	<tipc-discussion@...ts.sourceforge.net>, <linux-x25@...r.kernel.org>,
	<netfilter-devel@...r.kernel.org>, <coreteam@...filter.org>,
	<bridge@...ts.linux.dev>, <lvs-devel@...r.kernel.org>
Subject: Re: [PATCH net-next v6 0/8] sysctl: Remove sentinel elements from
 networking

On Wed, May 01, 2024 at 03:22:08PM +0200, Sabrina Dubroca wrote:
> 2024-05-01, 11:29:24 +0200, Joel Granados via B4 Relay wrote:
> > From: Joel Granados <j.granados@...sung.com>
> > 
...
> > Changes in v6:
> > - Rebased onto net-next/main.
> > - Besides re-running my cocci scripts, I ran a new find script [9].
> >   Found 0 hits in net/
> > - Moved "i" variable declaraction out of for() in sysctl_core_net_init
> > - Removed forgotten sentinel in mpls_table
> > - Removed CONFIG_AX25_DAMA_SLAVE guard from net/ax25/ax25_ds_timer.c. It
> >   is not needed because that file is compiled only when
> >   CONFIG_AX25_DAMA_SLAVE is set.
> > - When traversing smc_table, stop on ARRAY_SIZE instead of ARRAY_SIZE-1.
> > - Link to v5: https://lore.kernel.org/r/20240426-jag-sysctl_remset_net-v5-0-e3b12f6111a6@samsung.com
> 
> I pointed out a few tiny details in the ax25 patch but either way, the
> series looks good to me. Thanks!
> 
> Series:
> Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>
Thx

> 
> Note that you could have kept the ack/reviewed-by on patch 4 since it
> was not modified. Jeff and Chuck, your reviews got lost in the repost.
Indeed. I have been having issues with my b4. Have posted this
https://lore.kernel.org/tools/20240503120506.p7g5nn6jocrrdlck@joelS2.panther.com/
which explains my situation.

Best

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)