linux-kernel - RE: [PATCH v4 3/3] arm64: dts: freescale: add i.MX95 19x19 EVK minimal board dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB9417862B60AEE9656A529974881F2@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date: Fri, 3 May 2024 12:28:15 +0000
From: Peng Fan <peng.fan@....com>
To: Fabio Estevam <festevam@...il.com>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
 Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
	<kernel@...gutronix.de>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Alexander Stein
	<alexander.stein@...tq-group.com>
Subject: RE: [PATCH v4 3/3] arm64: dts: freescale: add i.MX95 19x19 EVK
 minimal board dts

> Subject: Re: [PATCH v4 3/3] arm64: dts: freescale: add i.MX95 19x19 EVK
> minimal board dts
> 
> Hi Peng,
> 
> On Thu, May 2, 2024 at 10:29 PM Peng Fan (OSS) <peng.fan@....nxp.com>
> wrote:
> 
> > +       aliases {
> > +               gpio0 = &gpio1;
> > +               gpio1 = &gpio2;
> > +               gpio2 = &gpio3;
> > +               gpio3 = &gpio4;
> > +               gpio4 = &gpio5;
> > +               i2c0 = &lpi2c1;
> > +               i2c1 = &lpi2c2;
> > +               i2c2 = &lpi2c3;
> > +               i2c3 = &lpi2c4;
> > +               i2c4 = &lpi2c5;
> > +               i2c5 = &lpi2c6;
> > +               i2c6 = &lpi2c7;
> > +               i2c7 = &lpi2c8;
> > +               mmc0 = &usdhc1;
> > +               mmc1 = &usdhc2;
> > +               mmc2 = &usdhc3;
> > +               serial0 = &lpuart1;
> > +               serial1 = &lpuart2;
> > +               serial2 = &lpuart3;
> > +               serial3 = &lpuart4;
> > +               serial4 = &lpuart5;
> > +               serial5 = &lpuart6;
> > +               serial6 = &lpuart7;
> > +               serial7 = &lpuart8;
> > +       };
> 
> This looks like an excessive aliases list.
> Can't you just have serial0, mmc0, and mmc1 instead?

ok, will drop other alias.

> 
> > +       reg_1p8v: regulator-1p8v {
> > +               compatible = "regulator-fixed";
> > +               regulator-max-microvolt = <1800000>;
> > +               regulator-min-microvolt = <1800000>;
> > +               regulator-name = "+V1.8_SW";
> > +       };
> > +
> > +       reg_3p3v: regulator-3p3v {
> > +               compatible = "regulator-fixed";
> > +               regulator-max-microvolt = <3300000>;
> > +               regulator-min-microvolt = <3300000>;
> > +               regulator-name = "+V3.3_SW";
> > +       };
> > +
> > +       reg_vref_1v8: regulator-adc-vref {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "vref_1v8";
> > +               regulator-min-microvolt = <1800000>;
> > +               regulator-max-microvolt = <1800000>;
> > +       };
> 
> These regulators are not used anywhere.
> 
> Please add them when they have consumers for them.

ok. Will drop the unused ones for now.

Thanks,
Peng.