linux-kernel - Re: [PATCH 1/2] dma-mapping: benchmark: fix up kthread creation error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 3 May 2024 13:36:30 +1200
From: Barry Song <21cnbao@...il.com>
To: Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Xiang Chen <chenxiang66@...ilicon.com>, Christoph Hellwig <hch@....de>, 
	Marek Szyprowski <m.szyprowski@...sung.com>, Robin Murphy <robin.murphy@....com>, 
	Barry Song <song.bao.hua@...ilicon.com>, iommu@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Alexey Khoroshilov <khoroshilov@...ras.ru>, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH 1/2] dma-mapping: benchmark: fix up kthread creation error handling

On Fri, May 3, 2024 at 4:29 AM Fedor Pchelkin <pchelkin@...ras.ru> wrote:
>
> If a kthread creation fails for some reason then uninitialized members of
> the tasks array will be accessed on the error path since it is allocated
> by kmalloc_array().
>
> Limit the bound in such case.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: 65789daa8087 ("dma-mapping: add benchmark support for streaming DMA APIs")
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
> ---

Reviewed-by: Barry Song <baohua@...nel.org>

>  kernel/dma/map_benchmark.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/dma/map_benchmark.c b/kernel/dma/map_benchmark.c
> index 02205ab53b7e..ea938bc6c7e3 100644
> --- a/kernel/dma/map_benchmark.c
> +++ b/kernel/dma/map_benchmark.c
> @@ -118,6 +118,7 @@ static int do_map_benchmark(struct map_benchmark_data *map)
>                 if (IS_ERR(tsk[i])) {
>                         pr_err("create dma_map thread failed\n");
>                         ret = PTR_ERR(tsk[i]);
> +                       threads = i;
>                         goto out;
>                 }
>
> --
> 2.45.0
>
>