linux-kernel - Re: [PATCH] stackleak: don't modify ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjTteMPELxCZTUSw@tycho.pizza>
Date: Fri, 3 May 2024 07:58:16 -0600
From: Tycho Andersen <tycho@...ho.pizza>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Kees Cook <keescook@...omium.org>,
	Alexander Popov <alex.popov@...ux.com>,
	linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>,
	Joel Granados <j.granados@...sung.com>
Subject: Re: [PATCH] stackleak: don't modify ctl_table argument

On Fri, May 03, 2024 at 03:44:09PM +0200, Thomas Weißschuh wrote:
> Sysctl handlers are not supposed to modify the ctl_table passed to them.
> Adapt the logic to work with a temporary
> variable, similar to how it is done in other parts of the kernel.
> 
> This is also a prerequisite to enforce the immutability of the argument
> through the callbacks prototy.
> 
> Fixes: 964c9dff0091 ("stackleak: Allow runtime disabling of kernel stack erasing")

Reviewed-by: Tycho Andersen <tycho@...ho.pizza>

Tycho