linux-kernel - Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 3 May 2024 10:41:04 +0900
From: Mark Brown <broonie@...nel.org>
To: Alina Yu <alina_yu@...htek.com>
Cc: lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	johnny_lai@...htek.com, cy_huang@...htek.com
Subject: Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with
 both fixed and adjustable vout

On Thu, May 02, 2024 at 05:26:14PM +0800, Alina Yu wrote:

> For the fixed LDO Vout, it will be set to either 0.9V or 1.2V, which are outside the range of 1.8V to 3.3V.
> The determination of whether it is fixed or adjustable lies solely with the user.
> This modification aims to ensure compatibility with the user's application.

That's a substantail reconfiguration of the regulator, it would be
better to have an explicit property for these non-standard fixed
voltages rather than trying to do this using constraints, or at the very
least have validation that the values being set are supported by the
hardware.  The code should also be very clear about what is going on.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)