linux-kernel - Re: [syzbot] [crypto?] KMSAN: uninit-value in skcipher_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000000000000c1a36406178db530@google.com>
Date: Fri, 03 May 2024 07:41:07 -0700
From: syzbot <syzbot+97b4444a5bd7bf30b3a8@...kaller.appspotmail.com>
To: n.zhandarovich@...tech.ru
Cc: linux-kernel@...r.kernel.org, n.zhandarovich@...tech.ru, 
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [crypto?] KMSAN: uninit-value in skcipher_walk_virt

> req->base.flags were not initialized, zero might suit in this case.
> Do it with skcipher_request_set_callback() as it's common practice.
>
> #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

This crash does not have a reproducer. I cannot test it.

>
> ---
>  fs/bcachefs/checksum.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/bcachefs/checksum.c b/fs/bcachefs/checksum.c
> index 7ed779b411f6..088fd2e7bdf1 100644
> --- a/fs/bcachefs/checksum.c
> +++ b/fs/bcachefs/checksum.c
> @@ -102,6 +102,7 @@ static inline int do_encrypt_sg(struct crypto_sync_skcipher *tfm,
>  	int ret;
>  
>  	skcipher_request_set_sync_tfm(req, tfm);
> +	skcipher_request_set_callback(req, 0, NULL, NULL);
>  	skcipher_request_set_crypt(req, sg, sg, len, nonce.d);
>  
>  	ret = crypto_skcipher_encrypt(req);