linux-kernel - Re: [PATCH] bitops: Change function return types from long to int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <d59d9b67-3f0c-423c-a76d-74056a8444cb@app.fastmail.com>
Date: Fri, 03 May 2024 17:05:39 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Thorsten Blum" <thorsten.blum@...lux.com>
Cc: 
 Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>,
 "Xiao W Wang" <xiao.w.wang@...el.com>,
 "Palmer Dabbelt" <palmer@...osinc.com>,
 "Charlie Jenkins" <charlie@...osinc.com>,
 "Namhyung Kim" <namhyung@...nel.org>, "Huacai Chen" <chenhuacai@...nel.org>,
 "Youling Tang" <tangyouling@...ngson.cn>,
 "Tiezhu Yang" <yangtiezhu@...ngson.cn>, "Jinyang He" <hejinyang@...ngson.cn>,
 Linux-Arch <linux-arch@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bitops: Change function return types from long to int

On Fri, May 3, 2024, at 16:49, Thorsten Blum wrote:
> On 22. Apr 2024, at 17:55, Arnd Bergmann <arnd@...db.de> wrote:
>>> 
>>> I can generally merge such a series with architecture specific
>>> changes through the asm-generic tree, with the appropriate Acks
>>> from the maintainers.
>
> What would it take for this patch (with only generic type changes) to be
> applied?
>
> I did some further investigations and disassembled my test kernel images.
> The patch reduced the number of ARM instructions by 872 with GCC 13 and by
> 2,354 with GCC 14. Other architectures that rely on the generic bitops
> functions will most likely also benefit from this patch.
>
> Tests were done with base commit 9d1ddab261f3e2af7c384dc02238784ce0cf9f98.

Sorry for failing to follow up earlier, I think this is ok, thanks
for your thorough work on this. I've applied it to the asm-generic
tree now.

     Arnd