linux-kernel - Re: [PATCH 2/5] x86/virt/tdx: Move TDMR metadata fields map table to local variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b78a383d-27bb-43e3-8e61-f8a6b25b2708@intel.com>
Date: Fri, 3 May 2024 09:01:31 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Kai Huang <kai.huang@...el.com>, linux-kernel@...r.kernel.org,
 kvm@...r.kernel.org
Cc: x86@...nel.org, kirill.shutemov@...ux.intel.com, peterz@...radead.org,
 tglx@...utronix.de, bp@...en8.de, mingo@...hat.com, hpa@...or.com,
 seanjc@...gle.com, pbonzini@...hat.com, isaku.yamahata@...el.com,
 jgross@...e.com
Subject: Re: [PATCH 2/5] x86/virt/tdx: Move TDMR metadata fields map table to
 local variable

On 3/1/24 03:20, Kai Huang wrote:
> The kernel reads all TDMR related global metadata fields based on a
> table which maps the metadata fields to the corresponding members of
> 'struct tdx_tdmr_sysinfo'.
> 
> Currently this table is a static variable.  But this table is only used
> by the function which reads these metadata fields and becomes useless
> after reading is done.

Is this intended to be a problem statement?  _How_ is this a problem?

> Change the table to function local variable.  This also saves the
> storage of the table from the kernel image.

I'm confused how this would happen.  Could you please explain your logic
a bit here?