linux-kernel - Re: [PATCH v2 1/1] selftests: cgroup: remove redundant addition of memory controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJD7tkbgknhot8Kz9jpF=0z1OHiLH5s3PfmbHd=TetrK7PtC6w@mail.gmail.com>
Date: Thu, 2 May 2024 19:06:50 -0700
From: Yosry Ahmed <yosryahmed@...gle.com>
To: Usama Arif <usamaarif642@...il.com>
Cc: akpm@...ux-foundation.org, hannes@...xchg.org, nphamcs@...il.com, 
	chengming.zhou@...ux.dev, linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	kernel-team@...a.com
Subject: Re: [PATCH v2 1/1] selftests: cgroup: remove redundant addition of
 memory controller

On Thu, May 2, 2024 at 1:05 PM Usama Arif <usamaarif642@...il.com> wrote:
>
> Memory controller is already added in main which invokes
> the test, hence this does not need to be done in test_no_kmem_bypass.

nit: The memory controller is "enabled", not added. Same for the subject line.

>
> Signed-off-by: Usama Arif <usamaarif642@...il.com>

Acked-by: Yosry Ahmed <yosryahmed@...gle.com>

> ---
>  tools/testing/selftests/cgroup/test_zswap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
> index cd864ab825d0..19ac29c533e0 100644
> --- a/tools/testing/selftests/cgroup/test_zswap.c
> +++ b/tools/testing/selftests/cgroup/test_zswap.c
> @@ -485,8 +485,6 @@ static int test_no_kmem_bypass(const char *root)
>         trigger_allocation_size = sys_info.totalram / 20;
>
>         /* Set up test memcg */
> -       if (cg_write(root, "cgroup.subtree_control", "+memory"))
> -               goto out;
>         test_group = cg_name(root, "kmem_bypass_test");
>         if (!test_group)
>                 goto out;
> --
> 2.43.0
>