linux-kernel - Re: [PATCH v1] ALSA: ASoc/tas2781: Fix an issue reported by robot kernel test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 04 May 2024 10:08:38 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Shenghao Ding <shenghao-ding@...com>
Cc: <broonie@...nel.org>,
	<andriy.shevchenko@...ux.intel.com>,
	<lgirdwood@...il.com>,
	<perex@...ex.cz>,
	<pierre-louis.bossart@...ux.intel.com>,
	<13916275206@....com>,
	<alsa-devel@...a-project.org>,
	<linux-kernel@...r.kernel.org>,
	<liam.r.girdwood@...el.com>,
	<bard.liao@...el.com>,
	<yung-chuan.liao@...ux.intel.com>,
	<kevin-lu@...com>,
	<cameron.berkenpas@...il.com>,
	<baojun.xu@...com>,
	<soyer@....hu>,
	<Baojun.Xu@....com>
Subject: Re: [PATCH v1] ALSA: ASoc/tas2781: Fix an issue reported by robot kernel test

On Sat, 04 May 2024 02:47:03 +0200,
Shenghao Ding wrote:
> 
> Fix an issue reported by robot kernel test and two harmless changes.

You need to describe more what was actually an issue reported by robot
kernel test here.  Otherwise it's nothing but a voodoo magic.

Also enumerate two harmless changes, too: it's an update of copyright
year and a correction of the comments.

Last but not least, the subject suffix should be "ASoC: tas2781: ..."
(not "ASoc", and without "ALSA:")


thanks,

Takashi

> 
> Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
> Signed-off-by: Shenghao Ding <shenghao-ding@...com>
> 
> ---
> v1:
>  - Changed the copyright year to 2024
>  - tasdevice-fmw.c --> tas2781-fmwlib.c
>  - | Reported-by: kernel test robot <lkp@...el.com>
>    | Closes: https://lore.kernel.org/oe-kbuild-all/202405021200.YHInjV43-lkp@intel.com/
> ---
>  sound/soc/codecs/tas2781-fmwlib.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
> index 45760fe19523..a6be81adcb83 100644
> --- a/sound/soc/codecs/tas2781-fmwlib.c
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
> @@ -1,8 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0
>  //
> -// tasdevice-fmw.c -- TASDEVICE firmware support
> +// tas2781-fmwlib.c -- TASDEVICE firmware support
>  //
> -// Copyright 2023 Texas Instruments, Inc.
> +// Copyright 2023 - 2024 Texas Instruments, Inc.
>  //
>  // Author: Shenghao Ding <shenghao-ding@...com>
>  
> @@ -1878,7 +1878,7 @@ int tas2781_load_calibration(void *context, char *file_name,
>  {
>  	struct tasdevice_priv *tas_priv = (struct tasdevice_priv *)context;
>  	struct tasdevice *tasdev = &(tas_priv->tasdevice[i]);
> -	const struct firmware *fw_entry;
> +	const struct firmware *fw_entry = NULL;
>  	struct tasdevice_fw *tas_fmw;
>  	struct firmware fmw;
>  	int offset = 0;
> -- 
> 2.34.1
>